sberlin commented on revision r996 in project google-guice.
Details are at http://code.google.com/p/google-guice/source/detail?r=996
Score: Positive
General Comment:
i'll do a more thorough test against our use-case in a bit, and post the
results in the bug.
Line-by-line comments:
File: /trunk/src/com/google/inject/InjectorBuilder.java (r996)
===============================================================================
Line 218: private boolean isEagerSingleton(InjectorImpl injector,
BindingImpl<?> binding, Stage stage) {
-------------------------------------------------------------------------------
looks straightforward enough. i'm not intricately familiar with the
binding hierarchy, so may be missing something. one thought that comes to
mind is that this may apply in more cases than we're expecting (and ones
that already work properly). for instance, if I have a parent injector
that binds AImpl.class & A.class to AImpl.class, it looks like this will
end up doing a callInContext twice (where before it only did it once). not
sure what the implications (possibly just performance?) are.
Respond to these comments at
http://code.google.com/p/google-guice/source/detail?r=996
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"google-guice-dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/google-guice-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
