[email protected] commented on revision r996 in project google-guice. Details are at http://code.google.com/p/google-guice/source/detail?r=996
General Comment: Sorry about commenting on this but I am curious. The root cause of this is that some JIT bindings end up at the root injector and don't get processed. It should be pretty much a one liner to eagerly build the root injectors JIT bindings again after building the current shells. // in InjectorBuilder#injectDynamically // after looping trough all the shells and building their eager singletons loadEagerSingletons(getRootInjector(shells.get(0).getInjector()),stage,errors); As a side effect all singletons will be eagerly created even the ones discovered when creating singletons. I find this more logical since afaik the point of production stage is to get as many singletons eagerly created as possible. Respond to these comments at http://code.google.com/p/google-guice/source/detail?r=996 -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/google-guice-dev?hl=en -~----------~----~----~----~------~----~------~--~---
