On Tue, Oct 21, 2008 at 12:51 AM, Stuart McCulloch <[EMAIL PROTECTED]> wrote: > 2008/10/21 Gili Tzabari <[EMAIL PROTECTED]> > > cglib is currently an internal dependency that's hidden from users > so using commons proxy would not change the public API, except > to let them choose which proxy to use - it would also add a level of > indirection internally, and may make Guice slightly harder to setup > (as the proxy libraries would then be managed externally)
I don't know if it would make it harder to set up. You could pick a default ProxyFactory implementation (CGLIB perhaps) and if users want to override that (with Javassist perhaps) then they could. It wouldn't be need to be something your users think about if they don't want to. > > so imho this wouldn't be a huge gain, compared to other features > on the issues list (and I wouldn't want it to delay the next release) > You're probably right. The big gain here would be slimming down Guice's codebase to not need all of that proxying logic. Since it'd be an internal thing primarily, I would agree that it shouldn't delay any release. I was just offering it up in case you folks didn't know about it and it could help your project. >> I'm not sure whether it does though or how well it is maintained. > > well, I'm sure James can answer that ;) I did notice that it still has > a dependency on cglib 2.1_3, which has a race condition - but I > assume cglib 2.2 can be dropped in without any recompilation > I already replied to the maintenance question. As far as that CGLIB dependency, I was unaware of the race condition and I would imagine that it could be swapped out with no issues. If you're using Maven and there is a newer version of CGLIB already declared in your pom, it will just use that. I need to release a new version of Commons Proxy anyway, I'll make sure the dependency is updated. If you want, you can file a JIRA issue (so that it doesn't look like I file all my own JIRAs :). I may "borrow" some of Guice's ASM code to provide an ASM-based implementation of ProxyFactory. Would anyone care to help implement it? --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/google-guice?hl=en -~----------~----~----~----~------~----~------~--~---
