On 6 Jul 2011, at 21:14, Anthony MULLER wrote: > Hello, > > Just to be sure to understand: why it is not possible to update jarjar if > it's tool currently have an issue?
jarjar only removes unused classes, it doesn't remove unused methods from those classes Often this distinction doesn't matter - but Guava has some utility classes like Maps that a) touch a wide range of collections classes and b) are themselves used by a lot of classes. I did submit a potential patch to let jarjar remove unused static methods (http://code.google.com/p/jarjar/issues/detail?id=22) but there wasn't much interest in adding that feature. > If Guice only use a few Guava classes, why to not copy them at build time? > It's probably not the clever solution but it could be the most efficient. Well you'd want to find the minimal set of classes to copy, but that is what jarjar does. The problem of just copying classes is that you may only call the ImmutableMap.of() method... but that class uses Maps, which uses Synchronized, which uses ForwardingIterator, etc... So you'd still end up including a lot of Guava classes that were never actually used by Guice, but just happened to be referenced from classes that were used by Guice. > Anthony > > Le 6 juillet 2011 22:08, Bob Lee <[email protected]> a écrit : > I use Guice in an Android app so I am sensitive to size. > > On Wed, Jul 6, 2011 at 7:12 AM, Sam Berlin <[email protected]> wrote: > The reasons why I think exposing the dependency is a bad idea: > > 1) Where do we stop? Should we expose cglib & asm as real dependencies that > can be upgraded too (real question)? That exposes the means by which Guice > is doing its bytecode manipulation for grabbing line numbers & for AOP. If > Guice decides to change how it does it, then people may have a false > dependency/requirement on cglib & asm. > > Cglib and ASM have been known to make incompatible changes. I'm pretty > confident that Guava will not from now on. > > Bob > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. > > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. -- You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-guice?hl=en.
