On 6 Jul 2011, at 21:25, Anthony MULLER wrote: > Ok, so I choose this option: > > 4) Build Guice core + extensions without any jarjar'ing or ProGuard'ing, > only do that as a final distribution / packaging step
Of course even if we decided to make Guava an external dependency we could always provide a separate "nodeps" flavour of Guice that embeds Guava (like CGLIB has a nodeps jar that embeds ASM) > Size is important for me and Guava is only an implementation detail (as > CGLIB, etc...) > > Cheers, > Anthony > > > Le 6 juillet 2011 22:16, Sam Berlin <[email protected]> a écrit : > This is exactly how JarJar works and what it does now. What JarJar doesn't > do (and what ProGuard does do) is trim out methods that are unused, avoiding > further dependencies used only by those methods. > > sam > > > On Wed, Jul 6, 2011 at 4:14 PM, Anthony MULLER <[email protected]> > wrote: > Hello, > > Just to be sure to understand: why it is not possible to update jarjar if > it's tool currently have an issue? > > If Guice only use a few Guava classes, why to not copy them at build time? > It's probably not the clever solution but it could be the most efficient. > > Anthony > > Le 6 juillet 2011 22:08, Bob Lee <[email protected]> a écrit : > > I use Guice in an Android app so I am sensitive to size. > > On Wed, Jul 6, 2011 at 7:12 AM, Sam Berlin <[email protected]> wrote: > The reasons why I think exposing the dependency is a bad idea: > > 1) Where do we stop? Should we expose cglib & asm as real dependencies that > can be upgraded too (real question)? That exposes the means by which Guice > is doing its bytecode manipulation for grabbing line numbers & for AOP. If > Guice decides to change how it does it, then people may have a false > dependency/requirement on cglib & asm. > > Cglib and ASM have been known to make incompatible changes. I'm pretty > confident that Guava will not from now on. > > Bob > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. > > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. > > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. > > > -- > You received this message because you are subscribed to the Google Groups > "google-guice" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-guice?hl=en. -- You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-guice?hl=en.
