On 6 Jul 2011, at 23:29, Fred Faber wrote: > On Wed, Jul 6, 2011 at 6:09 PM, Stuart McCulloch <[email protected]> wrote: > On 6 Jul 2011, at 17:53, Fred Faber wrote: >> Would it be sufficient to include Guava as an external dependency for the >> test suite, treating them as a client of Guice? Similarly for extensions? > > You mean make Guava an external dependency of the extensions, and not jarjar > any Guava references found in them? That would be another option, but I think > it would confuse people since they'd need to remember to add Guava as well as > the extension they actually wanted. > > Yes. And mind you I'm enjoying a game of devil's advocate right now,
no worries, I think it's important we consider all views :) > but folks would have to remember to add Guava as a dep when using Guice > proper, and so I don't think doing so when adding extensions would be much > worse. Especially given extensions could declare other deps as well. ... which then raises the question that if it's ok to have Guava as an extension dependency, why can't it be a core dependency? > >> Fred -- You received this message because you are subscribed to the Google Groups "google-guice" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-guice?hl=en.
