LGTM. Couple of nits:103 this could be a switch statement 34-84 - if you are going to have public static ints, do you still need the public accessor methods? Should those be private?
On Mon, Sep 8, 2008 at 2:20 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: > Attached the patch file... > > On Mon, Sep 8, 2008 at 2:19 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: > >> +GWTC >> >> >> On Mon, Sep 8, 2008 at 2:19 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: >> >>> Hello Miguel, >>> >>> This is yet another JS overlay conversion. The StatusCodes type is >>> really just a collection of constants. >>> >>> D maps/maps/src/com/google/gwt/maps/client/impl/StatusCodesImpl.java >>> M maps/maps/src/com/google/gwt/maps/client/geocode/StatusCodes.java >>> >>> -- >>> Eric Z. Ayers - GWT Team - Atlanta, GA USA >>> http://code.google.com/webtoolkit/ >>> >> >> >> >> -- >> Eric Z. Ayers - GWT Team - Atlanta, GA USA >> http://code.google.com/webtoolkit/ >> > > > > -- > Eric Z. Ayers - GWT Team - Atlanta, GA USA > http://code.google.com/webtoolkit/ > -- Miguel --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
