On Tue, Sep 9, 2008 at 9:36 AM, Miguel Méndez <[EMAIL PROTECTED]> wrote: > LGTM. Couple of nits: > 103 this could be a switch statement
Two of the members turn out to have the same value. Won't that kill the switch statement? MISSING_QUERY and UNKNOWN_ADDRESS bothmap to the numeric value 601. Sweet ain't it? I will document that first... > 34-84 - if you are going to have public static ints, do you still need the > public accessor methods? Should those be private? I exposed these on the conversion to overlays. I was considering dumping the static ints instead. This would save clinits, but at the expense of transparency for the JS Maps API docs. As a user of the API, I think I would prefer the constants though. > > On Mon, Sep 8, 2008 at 2:20 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: >> >> Attached the patch file... >> >> On Mon, Sep 8, 2008 at 2:19 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: >>> >>> +GWTC >>> >>> On Mon, Sep 8, 2008 at 2:19 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: >>>> >>>> Hello Miguel, >>>> >>>> This is yet another JS overlay conversion. The StatusCodes type is >>>> really just a collection of constants. >>>> >>>> D >>>> maps/maps/src/com/google/gwt/maps/client/impl/StatusCodesImpl.java >>>> M maps/maps/src/com/google/gwt/maps/client/geocode/StatusCodes.java >>>> >>>> -- >>>> Eric Z. Ayers - GWT Team - Atlanta, GA USA >>>> http://code.google.com/webtoolkit/ >>> >>> >>> >>> -- >>> Eric Z. Ayers - GWT Team - Atlanta, GA USA >>> http://code.google.com/webtoolkit/ >> >> >> >> -- >> Eric Z. Ayers - GWT Team - Atlanta, GA USA >> http://code.google.com/webtoolkit/ > > > > -- > Miguel > -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
