On 22 sep, 22:02, "Emily Crutcher" <[EMAIL PROTECTED]> wrote:
> A more complete implementation of the event handlers has been added to
> the gwt-incubator
> gen2.event
> package<http://code.google.com/p/google-web-toolkit-incubator/source/browse/#...>.
>
> The next step is to declare the design final, take the code from prototype
> to production and submit it to GWT trunk for inclusion in GWT 1.6, so this
> may be the last time any of you get a chance to holler if you don't like the
> system. The up-to-date design doc is
> here.<http://code.google.com/p/google-web-toolkit-incubator/wiki/ProposedEv...>
>
> For those of you who have been following the discussion already, the main
> changes are summarized below. Note, the design doc contains the actual
> design, this list is only for the convenience of those who have been closely
> following this thread:
>
> 1. Added a default Widget.onBrowserEvent
> 2. subscribeTo mechanism replaced by addAndSinkHandler mechanism
> 3. For each event type(ClickEvent used as an example)
> - ClickEvent.Source --> HasClickEvents
> - ClickEvent.fireEvent(Handler) --> ClickEvent.KEY.fire(Event,Handler)
LGTM but...
...have the keyDown/keyUp vs. keyPress been revised? (keyPress is
supposed to receive "characters" while keyDown/keyUp are "keys" –this
is the same as TextEvent vs. KeyboardEvent in DOM Level 3 Events–, see
also PPK's compatibility tables).
In the mean time, handling keys lead to some browser-specific tweaks
in your own code, whereas you would expect GWT to workaround those
differences/bugs for you and give you a predictable behavior.
http://www.w3.org/TR/DOM-Level-3-Events/events.html#Events-TextEvents-Interfaces
http://www.quirksmode.org/dom/events/index.html#t09
http://www.quirksmode.org/dom/w3c_events.html#keyprops
See also:
http://code.google.com/p/google-web-toolkit/issues/detail?id=72
http://code.google.com/p/google-web-toolkit/issues/detail?id=78
It would however affect issue 1566:
http://code.google.com/p/google-web-toolkit/issues/detail?id=1566
(just remove the ONKEYPRESS handling, but Opera doesn't repeat keydown
events; this could be worked around specifically for Opera with a
timer to synthetize keydown events until you receive a corresponding
keyup event)
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
