On Mon, Sep 22, 2008 at 7:43 PM, Thomas Broyer <[EMAIL PROTECTED]> wrote: > LGTM but... > > ...have the keyDown/keyUp vs. keyPress been revised? (keyPress is > supposed to receive "characters" while keyDown/keyUp are "keys" –this > is the same as TextEvent vs. KeyboardEvent in DOM Level 3 Events–, see > also PPK's compatibility tables). > In the mean time, handling keys lead to some browser-specific tweaks > in your own code, whereas you would expect GWT to workaround those > differences/bugs for you and give you a predictable behavior. > > http://www.w3.org/TR/DOM-Level-3-Events/events.html#Events-TextEvents-Interfaces > http://www.quirksmode.org/dom/events/index.html#t09 > http://www.quirksmode.org/dom/w3c_events.html#keyprops > > See also: > http://code.google.com/p/google-web-toolkit/issues/detail?id=72 > http://code.google.com/p/google-web-toolkit/issues/detail?id=78 > > It would however affect issue 1566: > http://code.google.com/p/google-web-toolkit/issues/detail?id=1566 > (just remove the ONKEYPRESS handling, but Opera doesn't repeat keydown > events; this could be worked around specifically for Opera with a > timer to synthetize keydown events until you receive a corresponding > keyup event)
I haven't been following too closely, so sorry if this is spam, but issue 1061 might be relevant, too. I haven't looked at the related code in quite a while, but I could always revisit it if necessary. http://code.google.com/p/google-web-toolkit/issues/detail?id=1061 Ian --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
