On Mon, Mar 16, 2009 at 11:16 PM, Scott Blum <[email protected]> wrote:
> - The whole PlatformSpecific -> CheckForUpdates stuff.. I think that looks > good, but can we do that first as a separate commit? > Ok. > - The BrowserListener diff seems unrelated also unless I'm missing > something > Well, I ran into the problem while testing this and it seemed like a good idea to fix it (the problem is avoiding a crash if the OOPHM socket was already in use). It can be separated out if you prefer. > - HostedModeBase: why are the two old protected methods being added back > in? > Hmm, looks like merge issues or getting overzealous moving stuff up from OOPHM/GWTShell, along with the call to doShouldCheckForUpdates in doStartup(). If we are moving the CheckForUpdates changes into a separate commit, then this file would be unchanged for now. > - OophmBrowserWidgetHostImpl should just subclass BrowserWidgetHostImpl, > right? This would remove a lot of duplicate code I think. > What code could it use? I don't see any method which is the same as HostedModeBase.BrowserWidgetHostImpl? > - ArgHandlerStartupURLsExtra should be in GWTShell, not OophmHostedModeBase > Ok. -- John A. Tamplin Software Engineer (GWT), Google --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
