I'm not 100% sure if this is related to the patch, but I'm seeing an issue in the following situation:
Started a project in OOPHM HostedMode Firefox 3.1 with plugin (version bumpbed to 3.1). Put laptop to sleep On wakeup, Firefox locks up. Now some variables do change - the connection drops out temporarily while the wireless is reconnecting to a different network (the laptop is moved to a different location while it's sleeping). Can anyone else confirm this issue? Obviously it's not the ideal set-up with FF3.1. On Mon, Mar 16, 2009 at 11:42 PM, John Tamplin <[email protected]> wrote: > On Mon, Mar 16, 2009 at 11:16 PM, Scott Blum <[email protected]> wrote: > >> - The whole PlatformSpecific -> CheckForUpdates stuff.. I think that looks >> good, but can we do that first as a separate commit? >> > > Ok. > > >> - The BrowserListener diff seems unrelated also unless I'm missing >> something >> > > Well, I ran into the problem while testing this and it seemed like a good > idea to fix it (the problem is avoiding a crash if the OOPHM socket was > already in use). It can be separated out if you prefer. > > >> - HostedModeBase: why are the two old protected methods being added back >> in? >> > > Hmm, looks like merge issues or getting overzealous moving stuff up from > OOPHM/GWTShell, along with the call to doShouldCheckForUpdates in > doStartup(). If we are moving the CheckForUpdates changes into a separate > commit, then this file would be unchanged for now. > > >> - OophmBrowserWidgetHostImpl should just subclass BrowserWidgetHostImpl, >> right? This would remove a lot of duplicate code I think. >> > > What code could it use? I don't see any method which is the same as > HostedModeBase.BrowserWidgetHostImpl? > > >> - ArgHandlerStartupURLsExtra should be in GWTShell, not >> OophmHostedModeBase >> > > Ok. > > -- > John A. Tamplin > Software Engineer (GWT), Google > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
