LGTM

I see a lot of tab characters, but the code looks great.  It also looks
like you've consolidated a lot of code.


http://gwt-code-reviews.appspot.com/29803/diff/1/5
File user/src/com/google/gwt/dom/DOM.gwt.xml (right):

http://gwt-code-reviews.appspot.com/29803/diff/1/5#newcode56
Line 56: <when-property-is name="user.agent" value="ie6"/>
too many spaces

http://gwt-code-reviews.appspot.com/29803/diff/1/12
File user/src/com/google/gwt/user/Form.gwt.xml (right):

http://gwt-code-reviews.appspot.com/29803/diff/1/12#newcode31
Line 31: <when-property-is name="user.agent" value="ie6"/>
Spacing, and what are those two red arrows?  »»

http://gwt-code-reviews.appspot.com/29803/diff/1/7
File user/src/com/google/gwt/user/RichText.gwt.xml (right):

http://gwt-code-reviews.appspot.com/29803/diff/1/7#newcode27
Line 27: <when-property-is name="user.agent" value="ie6" />
Remove the »», which I assume are tabs.

http://gwt-code-reviews.appspot.com/29803/diff/1/8
File user/src/com/google/gwt/user/TextBox.gwt.xml (right):

http://gwt-code-reviews.appspot.com/29803/diff/1/8#newcode32
Line 32: <when-property-is name="user.agent" value="ie6"/>
Remove »»

http://gwt-code-reviews.appspot.com/29803/diff/1/6
File user/src/com/google/gwt/xml/XML.gwt.xml (right):

http://gwt-code-reviews.appspot.com/29803/diff/1/6#newcode39
Line 39: <when-property-is name="user.agent" value="ie6"/>
tabs again »»

http://gwt-code-reviews.appspot.com/29803

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to