http://gwt-code-reviews.appspot.com/29803/diff/1/5 File user/src/com/google/gwt/dom/DOM.gwt.xml (right):
http://gwt-code-reviews.appspot.com/29803/diff/1/5#newcode56 Line 56: <when-property-is name="user.agent" value="ie6"/> On 2009/04/24 20:34:56, jlabanca wrote: > too many spaces Done. http://gwt-code-reviews.appspot.com/29803/diff/1/12 File user/src/com/google/gwt/user/Form.gwt.xml (right): http://gwt-code-reviews.appspot.com/29803/diff/1/12#newcode31 Line 31: <when-property-is name="user.agent" value="ie6"/> On 2009/04/24 20:34:56, jlabanca wrote: > Spacing, and what are those two red arrows? »» "visual tab indicators". Cleaned up tabs. http://gwt-code-reviews.appspot.com/29803/diff/1/7 File user/src/com/google/gwt/user/RichText.gwt.xml (right): http://gwt-code-reviews.appspot.com/29803/diff/1/7#newcode27 Line 27: <when-property-is name="user.agent" value="ie6" /> On 2009/04/24 20:34:56, jlabanca wrote: > Remove the »», which I assume are tabs. Done. http://gwt-code-reviews.appspot.com/29803/diff/1/8 File user/src/com/google/gwt/user/TextBox.gwt.xml (right): http://gwt-code-reviews.appspot.com/29803/diff/1/8#newcode32 Line 32: <when-property-is name="user.agent" value="ie6"/> On 2009/04/24 20:34:56, jlabanca wrote: > Remove »» Done. http://gwt-code-reviews.appspot.com/29803/diff/1/9 File user/src/com/google/gwt/user/UserAgent.gwt.xml (right): http://gwt-code-reviews.appspot.com/29803/diff/1/9#newcode38 Line 38: if (v >= 8000) { On 2009/04/24 23:44:41, t.broyer wrote: > I believe "ie8" here means "X-UA-Compatibility: IE=8", so detecting the version > from the navigator.userAgent is probably not enough [1], and > document.documentMode should be used instead [2], otherwise the "ie8" > implementation would have to do a > quirks-vs-standards-vs-super-standards-mode-detection, which would make the > "ie6" impl quite useless. > [1] Mike Ormond reports that a document can be displayed in IE=5 or IE=7 mode > while the UA is still reported as MSIE 8.0 http://blogs.msdn.com/mikeormond/archive/2008/09/25/ie-8-compatibility-meta-tags-http-headers-user-agent-strings-etc-etc.aspx > [2] http://msdn.microsoft.com/en-us/library/cc288325(VS.85).aspx#GetMode Thanks for pointing out that blog in particular. Amazing that they managed to turn quirks/standards into a 12-entry matrix :P The good news is that In "compatibility view", IE always reports its UA as MSIE 7.0, which triggers the "ie6" user-agent property. When no X-UA-Compatible header is set, we're in "normal mode" (i.e., not "compatibility view"), and no DOCTYPE is set, we end up in quirks-mode, which appears to turn off some IE8 features (I've noticed that at least IE8 history breaks, though everything else I've tried seems to work fine and all of our tests pass). The only solution I'm aware of is to either set a DOCTYPE or the X-UA-Compatible header (both of which will put you in standards-mode). I realize there are still some GWT panels that layout a bit oddly in standards-mode, and while we're working on solving this, it's going to be a problem for some apps for a while yet. I'll document this on the IE8 support wiki page for now. Before long, it will be the "right thing" to always set a DOCTYPE, which should make this problem go away. http://gwt-code-reviews.appspot.com/29803/diff/1/6 File user/src/com/google/gwt/xml/XML.gwt.xml (right): http://gwt-code-reviews.appspot.com/29803/diff/1/6#newcode39 Line 39: <when-property-is name="user.agent" value="ie6"/> On 2009/04/24 20:34:56, jlabanca wrote: > tabs again »» Done. http://gwt-code-reviews.appspot.com/29803 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
