My 2 c€nts.

...and this patch could also address issue 2815
http://code.google.com/p/google-web-toolkit/issues/detail?id=2815

(and do not forget issue 2938:
http://code.google.com/p/google-web-toolkit/issues/detail?id=2938 )


http://gwt-code-reviews.appspot.com/29803/diff/1/9
File user/src/com/google/gwt/user/UserAgent.gwt.xml (right):

http://gwt-code-reviews.appspot.com/29803/diff/1/9#newcode38
Line 38: if (v >= 8000) {
I believe "ie8" here means "X-UA-Compatibility: IE=8", so detecting the
version from the navigator.userAgent is probably not enough [1], and
document.documentMode should be used instead [2], otherwise the "ie8"
implementation would have to do a
quirks-vs-standards-vs-super-standards-mode-detection, which would make
the "ie6" impl quite useless.

[1] Mike Ormond reports that a document can be displayed in IE=5 or IE=7
mode while the UA is still reported as MSIE 8.0
http://blogs.msdn.com/mikeormond/archive/2008/09/25/ie-8-compatibility-meta-tags-http-headers-user-agent-strings-etc-etc.aspx

[2] http://msdn.microsoft.com/en-us/library/cc288325(VS.85).aspx#GetMode

http://gwt-code-reviews.appspot.com/29803

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to