http://gwt-code-reviews.appspot.com/62808/diff/1005/1021 File xpcom/install-template-ff2.rdf (right):
http://gwt-code-reviews.appspot.com/62808/diff/1005/1021#newcode34 Line 34: I realize this is a commented out TODO, but the urls should at least be correct. gwt-oophm -> gwt-dmp http://gwt-code-reviews.appspot.com/62808/diff/1005/1024 File xpcom/install-template-ff3+.rdf (right): http://gwt-code-reviews.appspot.com/62808/diff/1005/1024#newcode36 Line 36: gwt-oophm -> gwt-dmp http://gwt-code-reviews.appspot.com/62808/diff/1005/1023 File xpcom/install-template-ff3.rdf (right): http://gwt-code-reviews.appspot.com/62808/diff/1005/1023#newcode35 Line 35: gwt-devplugin->gwt-dmp http://gwt-code-reviews.appspot.com/62808/diff/1005/1022 File xpcom/install-template-ff35.rdf (right): http://gwt-code-reviews.appspot.com/62808/diff/1005/1022#newcode36 Line 36: gwt-oophm -> gwt-dmp http://gwt-code-reviews.appspot.com/62808/diff/31/45 File xpcom/Preferences.h (right): http://gwt-code-reviews.appspot.com/62808/diff/31/45#newcode22 Line 22: #include "nsISupports.h" These headers get pulled in from the include path set in the make file. Some of these headers seem only to exist in gecko-1.9.1/include. Means that if you are building for gecko-1.9.0 that the build would fail (as it does on my mac). http://gwt-code-reviews.appspot.com/62808/diff/31/51 File xpcom/prebuilt/extension/content/options.xul (right): http://gwt-code-reviews.appspot.com/62808/diff/31/51#newcode45 Line 45: <listbox id="listbox" rows="5"> The id should probably say what this UI item is supposed to be representing. Not simply the tag name. http://gwt-code-reviews.appspot.com/62808/diff/31/52 File xpcom/prebuilt/extension/content/prefScript.js (right): http://gwt-code-reviews.appspot.com/62808/diff/31/52#newcode12 Line 12: alert("Host name must not contain , or !"); wrap ',' and '!' these in single quotes so this message reads correctly. Other wise it sounds like a threat. Do not do it or !! http://gwt-code-reviews.appspot.com/62808/diff/31/52#newcode39 Line 39: prefs.splice(idx, 1); shouldnt this be prefs = prefs.splice(idx,1) http://gwt-code-reviews.appspot.com/62808/diff/31/52#newcode78 Line 78: prefs.QueryInterface(Components.interfaces.nsIPrefBranch2); shouldnt you be using the return of this queryinterface? http://gwt-code-reviews.appspot.com/62808/diff/31/52#newcode91 Line 91: prefs.QueryInterface(Components.interfaces.nsIPrefBranch2); shouldnt you be using the return of this queryinterface? http://gwt-code-reviews.appspot.com/62808 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
