Don't worry about the XUL or JS files -- Jaime will do those.
Preferences.{h,cpp} implement an interface to the Firefox preferences
system, including an observer for preferences changes. It's job is to
initially load the access list preference and supply it to the common
AllowedConnections code, and to update the access list whenever the
preference is changed (whether by the included preferences UI,
about:config, or some other plugin).
http://gwt-code-reviews.appspot.com/62808/diff/1005/1009
File common/AllowedConnections.cpp (right):
http://gwt-code-reviews.appspot.com/62808/diff/1005/1009#newcode46
Line 46: protoEnd += 3;
On 2009/08/28 14:51:03, amitmanjhi wrote:
> Minor nit. I would use a delimiter string assigned to "://" and use it
instead.
> 3 would become delimiter.length()
I really hate computing things at runtime which don't change. How about
a comment // strlen("://") == 3?
http://gwt-code-reviews.appspot.com/62808/diff/1005/1009#newcode55
Line 55: }
On 2009/08/28 14:51:03, amitmanjhi wrote:
> A substring call can be avoided here, if you just compute the position
of ':' in
> the url, with default being url.length(). host = url.substr(protoEnd,
min
> (hostEnd, colon))
Wouldn't that fail for http://foo.org/foo:bar.html?
http://gwt-code-reviews.appspot.com/62808/diff/1005/1009#newcode66
Line 66: // }
On 2009/08/28 14:51:03, amitmanjhi wrote:
> remove the commented code?
I was thinking when we added regex support we won't be able to use find
any more, so keeping the explicit iterator code would be useful then.
http://gwt-code-reviews.appspot.com/62808
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
