XUL and JS parts look good after addressing my last round of comments.

http://gwt-code-reviews.appspot.com/62808/diff/31/52
File xpcom/prebuilt/extension/content/prefScript.js (right):

http://gwt-code-reviews.appspot.com/62808/diff/31/52#newcode78
Line 78: prefs.QueryInterface(Components.interfaces.nsIPrefBranch2);
Basically the only thing you would need to change is to change each
prefs.QueryInterface() to
prefs = prefs.QueryInterface()

You don't necessarily have to check the return from the QI call.

http://gwt-code-reviews.appspot.com/62808

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to