http://gwt-code-reviews.appspot.com/63801/diff/1/2 File user/javadoc/com/google/gwt/examples/DockLayoutPanelExample.java (right):
http://gwt-code-reviews.appspot.com/63801/diff/1/2#newcode49 Line 49: rp.layout(); On 2009/09/03 04:34:04, Ray Ryan wrote: > So this doesn't call its children's layout methods? That seems like a shame. If > it does, then the p.layout method above is redundant, right? It does not. See comments below about RequiresLayout for a deeper discussion. http://gwt-code-reviews.appspot.com/63801/diff/1/3 File user/javadoc/com/google/gwt/examples/LayoutExample.java (right): http://gwt-code-reviews.appspot.com/63801/diff/1/3#newcode35 Line 35: // percentages. On 2009/09/03 04:34:04, Ray Ryan wrote: > Might as well make this the class comment. These samples get slurped up in generated doc without the enclosing class, so I have to keep the comments internal. > Worth mentioning that most app developers won't do this (right?), and what > they'd do instead. This will only ever be seen as part of the Layout class' doc, which itself points out that you probably don't want to use this directly. http://gwt-code-reviews.appspot.com/63801/diff/1/3#newcode43 Line 43: Element topChild = doc.createDivElement(), bottomChild = doc.createDivElement(); On 2009/09/03 04:34:04, Ray Ryan wrote: > long line Done. http://gwt-code-reviews.appspot.com/63801/diff/1/8 File user/src/com/google/gwt/layout/client/UserAgent.java (right): http://gwt-code-reviews.appspot.com/63801/diff/1/8#newcode24 Line 24: public class UserAgent { On 2009/09/03 04:34:04, Ray Ryan wrote: > should file an issue to make sure you remember to hit this TODO before 2.0 ships > (or make this not public again), or we'll be living with this for a long time... This shouldn't have been here in the first place. BobV's come up with a "soft permutations" system that will make this a lot simpler and more sensible. For the time being, I've simplified and hoisted this code into LayoutImplIE6 and made it private. http://gwt-code-reviews.appspot.com/63801 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
