Something is screwy with riedvelt, and I can't leave a comment on XSTemplate.js
My comment isn't really about your patch in particular, but the patterns we are using in the linker templates. I wish that stanzas of code common to many linkers, like the calling of __gwtStatsEvent() could be extracted and put into the template with variable substitution. For example, adding the sessionId field to the event works fine here, but there are several linkers outside of GWT that will need to be updated to get the same fix. -Eric. On Mon, Mar 15, 2010 at 6:17 PM, <[email protected]> wrote: > Reviewers: cromwellian, > > Description: > Support runAsync with the cross-site linker. > > > Please review this at http://gwt-code-reviews.appspot.com/213801 > > Affected files: > M > dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java > M dev/core/src/com/google/gwt/core/linker/IFrameLinker.java > M dev/core/src/com/google/gwt/core/linker/XSLinker.java > M dev/core/src/com/google/gwt/core/linker/XSTemplate.js > M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java > M dev/core/src/com/google/gwt/dev/jjs/impl/FragmentLoaderCreator.java > A > dev/core/src/com/google/gwt/dev/jjs/impl/HandleCrossIslandReferences.java > M dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java > M dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java > A dev/core/test/com/google/gwt/dev/js/JavaScriptStringTest.java > M user/src/com/google/gwt/core/CompilerParameters.gwt.xml > M user/src/com/google/gwt/core/Core.gwt.xml > A user/src/com/google/gwt/core/XSLinker.gwt.xml > user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java > A user/src/com/google/gwt/core/client/impl/CrossSiteLoadingStrategy.java > M user/src/com/google/gwt/core/client/impl/XhrLoadingStrategy.java > M user/test/com/google/gwt/core/client/impl/AsyncFragmentLoaderTest.java > M user/test/com/google/gwt/core/client/impl/XhrLoadingStrategyTest.java > A user/test/com/google/gwt/dev/jjs/CompilerSuiteCrossSite.gwt.xml > A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncFailure.gwt.xml > A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncMetrics.gwt.xml > A user/test/com/google/gwt/dev/jjs/CrossSiteRunAsyncSuite.java > M user/test/com/google/gwt/dev/jjs/RunAsyncFailure.gwt.xml > M user/test/com/google/gwt/dev/jjs/RunAsyncMetricsIntegrationTest.gwt.xml > user/test/com/google/gwt/dev/jjs/public/empty-gwt-stats.js > A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncFailureTest.java > A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncMetricsTest.java > A user/test/com/google/gwt/dev/jjs/test/CrossSiteRunAsyncTest.java > M user/test/com/google/gwt/dev/jjs/test/RunAsyncFailureTest.java > A > user/test/com/google/gwt/user/client/runasync/CrossSiteLoadingStrategyForRunAsyncFailureTest.java > D > user/test/com/google/gwt/user/server/runasync/RunAsyncFailureIFrameLinker.java > > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- Eric Z. Ayers Google Web Toolkit, Atlanta, GA USA Sign up now for Google I/O 2010: May 19-20, http://code.google.com/io -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
