On Fri, Apr 2, 2010 at 1:54 PM, <[email protected]> wrote: > I like the new overloads with String arguments. I've submitted them > before and had them bounce ("why do we need them?"), but they really do > shorten code. >
It should also save a tiny bit of memory to be able to use certain shared String instances directly, as opposed to always having to create a new String object on the unwrapped bytes. > Changing jprogram. to JProgram. seems not all that helpful, but if you > really want it, fine. It just seems like the kind of thing that is > going to toggle back and forth a lot over time. > It's really about the follow-up idea, which is to not have to pass the jprogram instance around in every case. You know though, it might be better to make these factory methods on the type being created. I'm not sure how these all ended up in JProgram to begin with. If you want to look at node-building, what would really help is to have > a node-building interface that has an instance method for every kind of > node. This would make it easy to remember how to build nodes, because > you'd always just go to that interface. It can also help us disentangle > the dependencies of the implementation. JProgram is a very heavy > dependency, and probably some things that currently depend on JProgram > could instead depend on a node builder. True. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe, reply using "remove me" as the subject.
