http://gwt-code-reviews.appspot.com/304801/diff/1/4 File dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java (right):
http://gwt-code-reviews.appspot.com/304801/diff/1/4#newcode771 dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java:771: char[][] name = typeDeclaration.binding.compoundName; On 2010/04/02 18:21:59, Lex wrote:
That change SGTM. I have a vague fear we will learn that the JDT guys
were
right and that arrays of chars are much faster. Until we really know,
let's use
the shorter code that uses String!
Done. http://gwt-code-reviews.appspot.com/304801/diff/1/4#newcode888 dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java:888: static String dotify(char[][] name) { I actually like the move out of JProgram. I think it's fine here because BuildTypeMap and GenerateJavaAST are really all part of the same thing, AST construction. It's just broken into two classes to make it easier to reason about. http://gwt-code-reviews.appspot.com/304801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
