http://gwt-code-reviews.appspot.com/707802/diff/1/5 File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right):
http://gwt-code-reviews.appspot.com/707802/diff/1/5#newcode391 dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:391: SpeedTracerLogger.get().start(CompilerEventType.MODULE_DEF, "phase", "refresh"); annotate data with the module name too http://gwt-code-reviews.appspot.com/707802/diff/1/7 File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java (right): http://gwt-code-reviews.appspot.com/707802/diff/1/7#newcode154 dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:154: @Override did you mean for these @Overrides to go in? http://gwt-code-reviews.appspot.com/707802/diff/1/14 File dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java (right): http://gwt-code-reviews.appspot.com/707802/diff/1/14#newcode1 dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java:1: /* FWIW, this file only contains whitespace changes. not sure if it makes sense to include in this patch (e.g. what the commit policy says about such files) http://gwt-code-reviews.appspot.com/707802/diff/1/15 File dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java (right): http://gwt-code-reviews.appspot.com/707802/diff/1/15#newcode1 dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java:1: /* likewise, only whitespace changes here http://gwt-code-reviews.appspot.com/707802/diff/1/19 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/707802/diff/1/19#newcode142 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:142: if (singleton == null) { this isn't thread safe. we probably won't hit the potential race condition in the current code, but I'd suggest just statically initializing here. i'd have to comb through the usage of init(), but it also seems problematic http://gwt-code-reviews.appspot.com/707802/diff/1/19#newcode233 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:233: currentEvent.durationNanos = endTimeNanos - currentEvent.startTimeNanos; should we also assert endTimeNanos >= currentEvent.startTimeNanos http://gwt-code-reviews.appspot.com/707802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
