LGTM

i still think the init() pattern is a bit strange but understand the
need it for testing. we can refine it later, but as long as we
implicitly enforce one call to init per possible run ourselves, then
everything should be fine.


http://gwt-code-reviews.appspot.com/707802/diff/14001/15016
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):

http://gwt-code-reviews.appspot.com/707802/diff/14001/15016#newcode150
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:150:
public synchronized static void init() {
perhaps note in the javadoc that this should only ever be called once
unless possibly in a unit test.

http://gwt-code-reviews.appspot.com/707802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to