Updated patch
http://gwt-code-reviews.appspot.com/707802/diff/1/5 File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right): http://gwt-code-reviews.appspot.com/707802/diff/1/5#newcode391 dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:391: SpeedTracerLogger.get().start(CompilerEventType.MODULE_DEF, "phase", "refresh"); On 2010/07/21 00:02:29, conroy wrote:
annotate data with the module name too
Done. http://gwt-code-reviews.appspot.com/707802/diff/1/7 File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java (right): http://gwt-code-reviews.appspot.com/707802/diff/1/7#newcode154 dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:154: @Override On 2010/07/21 00:02:29, conroy wrote:
did you mean for these @Overrides to go in?
Had save action turned on for Eclipse that added them. I turned it off. Done. http://gwt-code-reviews.appspot.com/707802/diff/1/14 File dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java (right): http://gwt-code-reviews.appspot.com/707802/diff/1/14#newcode1 dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java:1: /* On 2010/07/21 00:02:29, conroy wrote:
FWIW, this file only contains whitespace changes. not sure if it makes
sense to
include in this patch (e.g. what the commit policy says about such
files) Reverted. http://gwt-code-reviews.appspot.com/707802/diff/1/15 File dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java (right): http://gwt-code-reviews.appspot.com/707802/diff/1/15#newcode1 dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java:1: /* On 2010/07/21 00:02:29, conroy wrote:
likewise, only whitespace changes here
Reverted. http://gwt-code-reviews.appspot.com/707802/diff/1/19 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/707802/diff/1/19#newcode142 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:142: if (singleton == null) { On 2010/07/21 00:02:29, conroy wrote:
this isn't thread safe. we probably won't hit the potential race
condition in
the current code, but I'd suggest just statically initializing here.
i'd have to comb through the usage of init(), but it also seems
problematic I this I have resolved this by changing the semantics of get. I removed the auto-init from get() and synchronized the init() statements where singleton is set. http://gwt-code-reviews.appspot.com/707802/diff/1/19#newcode233 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:233: currentEvent.durationNanos = endTimeNanos - currentEvent.startTimeNanos; On 2010/07/21 00:02:29, conroy wrote:
should we also assert endTimeNanos >= currentEvent.startTimeNanos
Done. http://gwt-code-reviews.appspot.com/707802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
