LGTM to me to, w/ minor nits that don't need any further review.


http://gwt-code-reviews.appspot.com/719801/diff/18002/26011
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):

http://gwt-code-reviews.appspot.com/719801/diff/18002/26011#newcode68
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:68:
this.startTimeNanos = normalizedTimeNanos();
Could be auto initialized since both ctors initialize it the same way.

http://gwt-code-reviews.appspot.com/719801/diff/18002/26011#newcode130
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:130:
private static class LazySpeedTracerLoggerHolder {
I *believe* the only use for this class now is that it prevents
auto-initialization when running a unit test that only uses the
package-protected constructor.  We should either doc that fact
explicitly, or else get rid of this class as low-value.

http://gwt-code-reviews.appspot.com/719801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to