On 2010/07/27 22:36:22, zundel wrote:
Updated patch.

http://gwt-code-reviews.appspot.com/719801/diff/5001/6011
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):

http://gwt-code-reviews.appspot.com/719801/diff/5001/6011#newcode133

dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:133:
return singleton;
On 2010/07/27 21:20:39, conroy wrote:
> you want to move this get() to the outer class and have it reference
the field
> via LazySpeedTracerLoggerHolder.singleton
>
> (this can just replace the current get() and doesn't need the
synchronization
> overhead)

Done.

LGTM


http://gwt-code-reviews.appspot.com/719801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to