http://gwt-code-reviews.appspot.com/719801/diff/5001/6011 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right):
http://gwt-code-reviews.appspot.com/719801/diff/5001/6011#newcode72 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:72: if (data == null) { Actually, how could data ever be null? These are always invoked through varargs invocations. Same for line 85. http://gwt-code-reviews.appspot.com/719801/diff/5001/6011#newcode133 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:133: return singleton; I'm actually totally confused by this discussion. With this set of changes, it's no longer ever possible to change the value of singleton at all, right? So how about just make it a static final auto-init in SpeedTracerLogger and make init() do nothing? Then you don't even need the get() method anymore, just ref the static final field. http://gwt-code-reviews.appspot.com/719801/diff/5001/6011#newcode216 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:216: * {...@link #get()} is not affected. get() is now private, so this doc should probably get deleted. http://gwt-code-reviews.appspot.com/719801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
