http://gwt-code-reviews.appspot.com/704803/diff/1/2 File dev/core/src/com/google/gwt/dev/Compiler.java (right):
http://gwt-code-reviews.appspot.com/704803/diff/1/2#newcode211 dev/core/src/com/google/gwt/dev/Compiler.java:211: SpeedTracerLogger.end(precompileEventEvent); On 2010/08/05 18:53:45, scottb wrote:
It's shorter. If you *don't* do what Eric's suggesting, why are you
doing this
change at all?
The motivation for this is for two main reasons 1) Make addData sane. Currently you could accidentally add data in the middle of an event to a child event since you don't know what's on the stack and what isn't. 2) Unrolling missed events is problematic when just checking types. With this change, we can actually compare the event objects and unroll a lot cleaner. However, since it is more concise, I'll go ahead and make that change too. http://gwt-code-reviews.appspot.com/704803/diff/1/23 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/704803/diff/1/23#newcode59 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:59: public class Event { On 2010/08/05 18:53:45, scottb wrote:
Maybe split out public interface / private implementation like with
EventType? With only one implementation of Event, I don't see a need for an interface here. http://gwt-code-reviews.appspot.com/704803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
