LGTM with nits.

http://gwt-code-reviews.appspot.com/704803/diff/9001/10003
File dev/core/src/com/google/gwt/dev/DevModeBase.java (right):

http://gwt-code-reviews.appspot.com/704803/diff/9001/10003#newcode1085
dev/core/src/com/google/gwt/dev/DevModeBase.java:1085:
startupEvent.end();
you could consolidate the end() to one call as follows:

result = doSlowStartup();
if (!result) {
   log(...);
}
startupEvent.end();
return result;

http://gwt-code-reviews.appspot.com/704803/diff/9001/10010
File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
(right):

http://gwt-code-reviews.appspot.com/704803/diff/9001/10010#newcode210
dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:210:
Event compilationSTateBuilderProcess =
wEiRd caps

http://gwt-code-reviews.appspot.com/704803/diff/9001/10016
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):

http://gwt-code-reviews.appspot.com/704803/diff/9001/10016#newcode1024
dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:1024:
Event soyc =
SpeedTracerLogger.start(CompilerEventType.MAKE_SOYC_ARTIFACTS);
You left off the 'Event' suffix from these vars which makes the .end()
calls a little lese readable.

http://gwt-code-reviews.appspot.com/704803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to