http://gwt-code-reviews.appspot.com/760802/diff/6001/1029 File samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml (right):
http://gwt-code-reviews.appspot.com/760802/diff/6001/1029#newcode3 samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:3: <!-- Copyright 2007 Google Inc. --> Update copyright date for new code. http://gwt-code-reviews.appspot.com/760802/diff/6001/1030 File samples/validation/src/com/google/gwt/sample/validation/client/GreetingService.java (right): http://gwt-code-reviews.appspot.com/760802/diff/6001/1030#newcode26 samples/validation/src/com/google/gwt/sample/validation/client/GreetingService.java:26: public interface GreetingService extends RemoteService { Since this is new, please use com.google.gwt.rpc.client.RpcService and rpc.server.RpcServlet to use the deRPC code-base (which I'd like to make the new default in 2.1). No other changes are required. http://gwt-code-reviews.appspot.com/760802/diff/6001/1032 File samples/validation/src/com/google/gwt/sample/validation/client/Validation.java (right): http://gwt-code-reviews.appspot.com/760802/diff/6001/1032#newcode55 samples/validation/src/com/google/gwt/sample/validation/client/Validation.java:55: public void onModuleLoad() { Please UIBinder-ize this. http://gwt-code-reviews.appspot.com/760802/diff/6001/1032#newcode107 samples/validation/src/com/google/gwt/sample/validation/client/Validation.java:107: public void onClick(ClickEvent event) { This inner class can go, replaced with @UiHandler("closeButton") void onKeyUp(KeyUpEvent evt) {...} @UiHandler("closeButton) void onClick(ClickEvent evt) {...} http://gwt-code-reviews.appspot.com/760802/diff/6001/1033 File samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java (right): http://gwt-code-reviews.appspot.com/760802/diff/6001/1033#newcode52 samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java:52: private String escapeHtml(String html) { Add a TODO here to use SafeHtml after it's integrated. http://gwt-code-reviews.appspot.com/760802/diff/6001/1035 File samples/validation/war/Validation.css (right): http://gwt-code-reviews.appspot.com/760802/diff/6001/1035#newcode1 samples/validation/war/Validation.css:1: /** Add css rules here for your application. */ Move into .ui.xml file. http://gwt-code-reviews.appspot.com/760802/diff/6001/1035#newcode19 samples/validation/war/Validation.css:19: .gwt-DialogBox { Add to the ui:style @external .gwt-*; to disable obfuscation for the .gwt-DialogBox selector. http://gwt-code-reviews.appspot.com/760802/diff/6001/1036 File samples/validation/war/Validation.html (right): http://gwt-code-reviews.appspot.com/760802/diff/6001/1036#newcode3 samples/validation/war/Validation.html:3: <!-- Copyright 2008 Google Inc. --> Update date. http://gwt-code-reviews.appspot.com/760802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
