I will need a g4 approved also On Aug 25, 2010 5:26 AM, <[email protected]> wrote: > LGTM > > > http://gwt-code-reviews.appspot.com/760802/diff/6001/1032 > File > samples/validation/src/com/google/gwt/sample/validation/client/Validation.java > (right): > > http://gwt-code-reviews.appspot.com/760802/diff/6001/1032#newcode55 > samples/validation/src/com/google/gwt/sample/validation/client/Validation.java:55: > public void onModuleLoad() { >> Note this is what the Eclipse, create a sample app does. > > Looks like the webapp sample creator is a few years behind the curve. > I'll file a bug about modernizing it. > > http://gwt-code-reviews.appspot.com/760802/diff/20001/21007 > File samples/build.xml (right): > > http://gwt-code-reviews.appspot.com/760802/diff/20001/21007#newcode37 > samples/build.xml:37: <target name="validation" description="Build > validaiton"> > typo in the description attribute. > > http://gwt-code-reviews.appspot.com/760802/diff/20001/21010 > File > samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml > (right): > > http://gwt-code-reviews.appspot.com/760802/diff/20001/21010#newcode2 > samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:2: > <!DOCTYPE module PUBLIC "-//Google Inc.//DTD Google Web Toolkit > 0.0.999//EN" > " http://google-web-toolkit.googlecode.com/svn/tags/0.0.999/distro-source/core/src/gwt-module.dtd "> > This doctype produced by the webapp creator is wrong and unnecessary. > > http://gwt-code-reviews.appspot.com/760802/show
-- http://groups.google.com/group/Google-Web-Toolkit-Contributors
