http://gwt-code-reviews.appspot.com/760802/diff/6001/1029 File samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml (right):
http://gwt-code-reviews.appspot.com/760802/diff/6001/1029#newcode3 samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:3: <!-- Copyright 2007 Google Inc. --> On 2010/08/23 13:35:14, bobv wrote:
Update copyright date for new code.
Done. http://gwt-code-reviews.appspot.com/760802/diff/6001/1030 File samples/validation/src/com/google/gwt/sample/validation/client/GreetingService.java (right): http://gwt-code-reviews.appspot.com/760802/diff/6001/1030#newcode26 samples/validation/src/com/google/gwt/sample/validation/client/GreetingService.java:26: public interface GreetingService extends RemoteService { On 2010/08/23 13:35:14, bobv wrote:
Since this is new, please use
com.google.gwt.rpc.client.RpcService and rpc.server.RpcServlet
to use the deRPC code-base (which I'd like to make the new default in
2.1). No
other changes are required.
Done. http://gwt-code-reviews.appspot.com/760802/diff/6001/1032 File samples/validation/src/com/google/gwt/sample/validation/client/Validation.java (right): http://gwt-code-reviews.appspot.com/760802/diff/6001/1032#newcode55 samples/validation/src/com/google/gwt/sample/validation/client/Validation.java:55: public void onModuleLoad() { On 2010/08/23 13:35:14, bobv wrote:
Please UIBinder-ize this.
Sure, Note this is what the Eclipse, create a sample app does. http://gwt-code-reviews.appspot.com/760802/diff/6001/1033 File samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java (right): http://gwt-code-reviews.appspot.com/760802/diff/6001/1033#newcode52 samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java:52: private String escapeHtml(String html) { On 2010/08/23 13:35:14, bobv wrote:
Add a TODO here to use SafeHtml after it's integrated.
Done. http://gwt-code-reviews.appspot.com/760802/diff/6001/1035 File samples/validation/war/Validation.css (right): http://gwt-code-reviews.appspot.com/760802/diff/6001/1035#newcode1 samples/validation/war/Validation.css:1: /** Add css rules here for your application. */ On 2010/08/23 13:35:14, bobv wrote:
Move into .ui.xml file.
Done. Except for the h1, which I left in the HTML page. http://gwt-code-reviews.appspot.com/760802/diff/6001/1035#newcode19 samples/validation/war/Validation.css:19: .gwt-DialogBox { On 2010/08/23 13:35:14, bobv wrote:
Add to the ui:style
@external .gwt-*;
to disable obfuscation for the .gwt-DialogBox selector.
Done. http://gwt-code-reviews.appspot.com/760802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
