http://gwt-code-reviews.appspot.com/959801/diff/4001/5001
File
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
(right):

http://gwt-code-reviews.appspot.com/959801/diff/4001/5001#newcode1381
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:1381:
* send an UPDATE if the client is at a version different than that of
the
s/s/S/

http://gwt-code-reviews.appspot.com/959801/diff/4001/5001#newcode1382
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:1382:
* server or if the server version has changed.
or if the server version has changed after invoking the domain method.

http://gwt-code-reviews.appspot.com/959801/diff/4001/5001#newcode1385
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:1385:
assert entityInstanceAfterOperation != null;
Unnecessary assert.

http://gwt-code-reviews.appspot.com/959801/diff/4001/5001#newcode1445
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:1445:
SerializedEntity beforeEntity = beforeDataMap.get(entityKey);
What would a null beforeEntity imply?  That the key was just created on
the server?

http://gwt-code-reviews.appspot.com/959801/diff/4001/5002
File
user/test/com/google/gwt/requestfactory/server/JsonRequestProcessorTest.java
(right):

http://gwt-code-reviews.appspot.com/959801/diff/4001/5002#newcode150
user/test/com/google/gwt/requestfactory/server/JsonRequestProcessorTest.java:150:
public void testEndToEndSmartDiff_NoChange() throws Exception {
Install eclemma and verify coverage before submitting.

http://gwt-code-reviews.appspot.com/959801/diff/4001/5003
File user/test/com/google/gwt/requestfactory/server/SimpleFoo.java
(right):

http://gwt-code-reviews.appspot.com/959801/diff/4001/5003#newcode283
user/test/com/google/gwt/requestfactory/server/SimpleFoo.java:283: *
increment version numbers.
No plans to implement a server version of AutoBeans at present.

http://gwt-code-reviews.appspot.com/959801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to