http://gwt-code-reviews.appspot.com/959801/diff/4001/5001
File
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
(right):

http://gwt-code-reviews.appspot.com/959801/diff/4001/5001#newcode78
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:78:
this.version = givenVersion;
Not done.

http://gwt-code-reviews.appspot.com/959801/diff/12002/13002
File
user/test/com/google/gwt/requestfactory/server/JsonRequestProcessorTest.java
(right):

http://gwt-code-reviews.appspot.com/959801/diff/12002/13002#newcode199
user/test/com/google/gwt/requestfactory/server/JsonRequestProcessorTest.java:199:
public void testEndToEndSmartDiff_NoChange_NoVersion() throws Exception
{
If I read this right, you're testing a config that has nothing to do
with
reality — the domain object has a version number, but the browser has
dropped
it. The interesting test is of a domain object that has no version
number, or at
least no version change. Since you have properties that don't tickle the
version, that shouldn't be hard to write.

Am I confused?

http://gwt-code-reviews.appspot.com/959801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to