On Tue, Oct 5, 2010 at 4:10 PM, <[email protected]> wrote: > > http://gwt-code-reviews.appspot.com/959801/diff/5004/20001 > > File > user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java > (right): > > http://gwt-code-reviews.appspot.com/959801/diff/5004/20001#newcode77 > user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:77: > this.version = (Integer) > (jsonObject.has(Constants.ENCODED_VERSION_PROPERTY) > Why are you hard coding this requirement that the thing be an integer? > > The version property is currently hard coded to be an Integer. I'm just using that here.
> http://gwt-code-reviews.appspot.com/959801/diff/5004/20002 > > File > > user/test/com/google/gwt/requestfactory/server/JsonRequestProcessorTest.java > (right): > > http://gwt-code-reviews.appspot.com/959801/diff/5004/20002#newcode200 > > user/test/com/google/gwt/requestfactory/server/JsonRequestProcessorTest.java:200: > > public void testEndToEndSmartDiff_NoChange_NoVersion() throws Exception > { > Why keep the test that tests surviving what would be a client bug? > > > http://gwt-code-reviews.appspot.com/959801/show > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
