http://gwt-code-reviews.appspot.com/972801/diff/1/8 File samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java (right):
http://gwt-code-reviews.appspot.com/972801/diff/1/8#newcode41 samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java:41: Validator validator = Validation.buildDefaultValidatorFactory().getValidator(); On 2010/10/11 19:04:03, bobv wrote:
Should these fields be private?
Done. http://gwt-code-reviews.appspot.com/972801/diff/1/8#newcode51 samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java:51: temp.addAll(violations); On 2010/10/11 19:04:03, bobv wrote:
new HashSet(violations) instead of the addAll?
Done. http://gwt-code-reviews.appspot.com/972801/diff/1/15 File samples/validation/src/com/google/gwt/sample/validation/super/com/google/gwt/sample/validation/shared/ServerValidator.java (right): http://gwt-code-reviews.appspot.com/972801/diff/1/15#newcode25 samples/validation/src/com/google/gwt/sample/validation/super/com/google/gwt/sample/validation/shared/ServerValidator.java:25: * {...@link com.google.gwt.validation.client.constraints.NotGwtCompatibleValidator} On 2010/10/11 19:04:03, bobv wrote:
Any reason not to do this now?
Until groups are properly handled there is no way to avoid running this on the client, since it always fails the message will never go to the server which is what I am trying to test. http://gwt-code-reviews.appspot.com/972801/diff/1/19 File user/src/org/hibernate/validator/engine/ConstraintViolationImpl_CustomFieldSerializer.java (right): http://gwt-code-reviews.appspot.com/972801/diff/1/19#newcode61 user/src/org/hibernate/validator/engine/ConstraintViolationImpl_CustomFieldSerializer.java:61: streamWriter.writeString(instance.getMessageTemplate()); On 2010/10/11 19:04:03, bobv wrote:
Isn't the message template usually implementation-specific?
I thin you are right removing it. http://gwt-code-reviews.appspot.com/972801/diff/1/21 File user/src/org/hibernate/validator/super/org/hibernate/validator/engine/PathImpl.java (right): http://gwt-code-reviews.appspot.com/972801/diff/1/21#newcode18 user/src/org/hibernate/validator/super/org/hibernate/validator/engine/PathImpl.java:18: // Modified by Google On 2010/10/11 19:04:03, bobv wrote:
What modifications were made?
Done. http://gwt-code-reviews.appspot.com/972801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
