http://gwt-code-reviews.appspot.com/972801/diff/1/8 File samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java (right):
http://gwt-code-reviews.appspot.com/972801/diff/1/8#newcode41 samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java:41: Validator validator = Validation.buildDefaultValidatorFactory().getValidator(); Should these fields be private? http://gwt-code-reviews.appspot.com/972801/diff/1/8#newcode51 samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java:51: temp.addAll(violations); new HashSet(violations) instead of the addAll? http://gwt-code-reviews.appspot.com/972801/diff/1/15 File samples/validation/src/com/google/gwt/sample/validation/super/com/google/gwt/sample/validation/shared/ServerValidator.java (right): http://gwt-code-reviews.appspot.com/972801/diff/1/15#newcode25 samples/validation/src/com/google/gwt/sample/validation/super/com/google/gwt/sample/validation/shared/ServerValidator.java:25: * {...@link com.google.gwt.validation.client.constraints.NotGwtCompatibleValidator} Any reason not to do this now? http://gwt-code-reviews.appspot.com/972801/diff/1/19 File user/src/org/hibernate/validator/engine/ConstraintViolationImpl_CustomFieldSerializer.java (right): http://gwt-code-reviews.appspot.com/972801/diff/1/19#newcode59 user/src/org/hibernate/validator/engine/ConstraintViolationImpl_CustomFieldSerializer.java:59: // the client side has to "know" where the "path" starts. Style: block comment This is the same question posed by RequestFactory after it calls the validator on the server. In the end, we decided that passing the message and path were enough. With the more general case you're addressing here, there's no guarantee that the root bean is GWT-serializable or that it's appropriate for it to be exposed on the client. Even if the root bean could be sent back, the lack of reflection on the client makes it troublesome to interpret the path as a sequence of property accesses. Starting off with the simplest-to-implement properties is the right choice. http://gwt-code-reviews.appspot.com/972801/diff/1/19#newcode61 user/src/org/hibernate/validator/engine/ConstraintViolationImpl_CustomFieldSerializer.java:61: streamWriter.writeString(instance.getMessageTemplate()); Isn't the message template usually implementation-specific? http://gwt-code-reviews.appspot.com/972801/diff/1/21 File user/src/org/hibernate/validator/super/org/hibernate/validator/engine/PathImpl.java (right): http://gwt-code-reviews.appspot.com/972801/diff/1/21#newcode18 user/src/org/hibernate/validator/super/org/hibernate/validator/engine/PathImpl.java:18: // Modified by Google What modifications were made? http://gwt-code-reviews.appspot.com/972801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
