LGTM, just nits.

http://gwt-code-reviews.appspot.com/972801/diff/8001/9007
File
samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java
(right):

http://gwt-code-reviews.appspot.com/972801/diff/8001/9007#newcode66
samples/validation/src/com/google/gwt/sample/validation/server/GreetingServiceImpl.java:66:
.appendEscaped("" + userAgent)//
Unnecessary string concatenation?

http://gwt-code-reviews.appspot.com/972801/diff/8001/9018
File
user/src/org/hibernate/validator/engine/ConstraintViolationImpl_CustomFieldSerializer.java
(right):

http://gwt-code-reviews.appspot.com/972801/diff/8001/9018#newcode65
user/src/org/hibernate/validator/engine/ConstraintViolationImpl_CustomFieldSerializer.java:65:
// choice.
I meant that you should make the comment that was there a /**/ comment
and that I agreed with your choice.

http://gwt-code-reviews.appspot.com/972801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to