LGTM

Really nice, just one nit below.


http://gwt-code-reviews.appspot.com/993801/diff/7001/8001
File user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
(right):

http://gwt-code-reviews.appspot.com/993801/diff/7001/8001#newcode185
user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java:185:
if (ambiguousSetters.contains(propertyName)) {
You still don't need this contains check. It's okay to try to remove
something that isn't there, and your own check is redundant with the
set's check.

http://gwt-code-reviews.appspot.com/993801/diff/7001/8001#newcode192
user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java:192:
if (!ambiguousSetters.contains(propertyName)) {
Ditto.

http://gwt-code-reviews.appspot.com/993801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to