A second entry point for compile makes a lot of sense - and maybe for
CompilePerms too. Keep looking and tell me what you think.

I'm thinking of these names:

PrecompileOnePerm for the new precompile entry point.
CompileOnePerm for the new compile perms entry point

With those names we can dicard all the handing of multiple modules and
multiple permutations and greatly simplify those
entry points.

There may be some reformatting of code, but believe me, I have worked
hard to keep that to a minimum, so if you see a file with lots of
changes and not just a stray missing space at EOL, let me know.



http://gwt-code-reviews.appspot.com/1074801/diff/7001/8006
File dev/core/src/com/google/gwt/dev/Precompile.java (right):

http://gwt-code-reviews.appspot.com/1074801/diff/7001/8006#newcode702
dev/core/src/com/google/gwt/dev/Precompile.java:702: if (!new
File(compilerWorkDir, AnalyzeModule.OPTIONS_FILENAME).isFile()) {
On 2010/11/04 20:43:59, scottb wrote:
How do you know whether this wasn't left from a previous compile?

Well, you don't really.  That alone is proabably enough to justify a new
entry point.

http://gwt-code-reviews.appspot.com/1074801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to