Additional comments.

http://gwt-code-reviews.appspot.com/1074801/diff/7001/8004
File dev/core/src/com/google/gwt/dev/CompilePerms.java (right):

http://gwt-code-reviews.appspot.com/1074801/diff/7001/8004#newcode228
dev/core/src/com/google/gwt/dev/CompilePerms.java:228: PrecompileOptions
precompilationOptions =
I don't understand why this is changing.  Shouldn't Precompile consume
AnalyzeModuleOptions and produce PrecompilationResult unconditionally?
Why does this phase sometimes want to consume AnalyzeModuleOptions?

http://gwt-code-reviews.appspot.com/1074801/diff/7001/8005
File dev/core/src/com/google/gwt/dev/Link.java (right):

http://gwt-code-reviews.appspot.com/1074801/diff/7001/8005#newcode506
dev/core/src/com/google/gwt/dev/Link.java:506: }
Unrelated to patch?

http://gwt-code-reviews.appspot.com/1074801/diff/7001/8005#newcode561
dev/core/src/com/google/gwt/dev/Link.java:561: // AnalyzeModule
Same comment as with CompilePerms.

http://gwt-code-reviews.appspot.com/1074801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to