Updated patch
http://gwt-code-reviews.appspot.com/1074801/diff/7001/8003 File dev/core/src/com/google/gwt/dev/AnalyzeModule.java (right): http://gwt-code-reviews.appspot.com/1074801/diff/7001/8003#newcode47 dev/core/src/com/google/gwt/dev/AnalyzeModule.java:47: private final PrecompileOptionsImpl precompileOptions = new PrecompileOptionsImpl(); On 2010/11/04 20:43:59, scottb wrote:
Why does this both nest, and extend? Pick one.
Done. http://gwt-code-reviews.appspot.com/1074801/diff/7001/8003#newcode73 dev/core/src/com/google/gwt/dev/AnalyzeModule.java:73: private interface AnalyzeModuleOptions extends Precompile.PrecompileOptions { On 2010/11/04 20:43:59, scottb wrote:
Maybe doc that the only reason for this class is to support future
options. But
honestly, I think I wouldn't bother creating new types for this or
ArgProcessor
and just reused the Precompile ones directly until some time where we
actually
do extend them.
Done. http://gwt-code-reviews.appspot.com/1074801/diff/7001/8003#newcode114 dev/core/src/com/google/gwt/dev/AnalyzeModule.java:114: * Silently returns <pre>null</pre> if the file is not found or another On 2010/11/04 20:43:59, scottb wrote:
Use <code>null</code> instead of pre.
Fixed locally (not yet uploaded) http://gwt-code-reviews.appspot.com/1074801/diff/18001/19001#newcode168 dev/core/src/com/google/gwt/dev/AnalyzeModule.java:168: */ reformatted locally http://gwt-code-reviews.appspot.com/1074801/diff/18001/19003 File dev/core/src/com/google/gwt/dev/CompilePerms.java (right): http://gwt-code-reviews.appspot.com/1074801/diff/18001/19003#newcode2 dev/core/src/com/google/gwt/dev/CompilePerms.java:2: * Copyright 2008 Google Inc. this file is now mostly reverted back to its original state - I only refactored a bit to be able to share code with CompileOnePerm http://gwt-code-reviews.appspot.com/1074801/diff/18001/19006 File dev/core/src/com/google/gwt/dev/Precompile.java (right): http://gwt-code-reviews.appspot.com/1074801/diff/18001/19006#newcode2 dev/core/src/com/google/gwt/dev/Precompile.java:2: * Copyright 2008 Google Inc. I reverted this file, then refactored only slightly so I could share code with PrecompileOnePerm. http://gwt-code-reviews.appspot.com/1074801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
