NumberLabel/DateLabel parts look good to me with minor issues.
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27005 File user/src/com/google/gwt/uibinder/elementparsers/NumberLabelParser.java (right): http://gwt-code-reviews.appspot.com/1099801/diff/26001/27005#newcode70 user/src/com/google/gwt/uibinder/elementparsers/NumberLabelParser.java:70: writer.getOracle().findType(CurrencyData.class.getCanonicalName())); How do you get a CurrencyData instance from the ui.xml file? http://gwt-code-reviews.appspot.com/1099801/diff/26001/27025 File user/test/com/google/gwt/uibinder/elementparsers/DateLabelParserTest.java (right): http://gwt-code-reviews.appspot.com/1099801/diff/26001/27025#newcode230 user/test/com/google/gwt/uibinder/elementparsers/DateLabelParserTest.java:230: public void testChokeOnUnknownPredefinedFormat() throws SAXException { Should there be a test that shows predefinedFormat working and having the right output? http://gwt-code-reviews.appspot.com/1099801/diff/26001/27026 File user/test/com/google/gwt/uibinder/elementparsers/NumberLabelParserTest.java (right): http://gwt-code-reviews.appspot.com/1099801/diff/26001/27026#newcode145 user/test/com/google/gwt/uibinder/elementparsers/NumberLabelParserTest.java:145: b.append("<g:NumberLabel predefinedFormat='CURRENCY'>"); I like the parallelism with DateTimeFormat, and we probably should make a similar change to it that includes a PredefinedFormat enum. http://gwt-code-reviews.appspot.com/1099801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
