http://gwt-code-reviews.appspot.com/1099801/diff/26001/27009 File user/src/com/google/gwt/user/client/ui/DateLabel.java (right):
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27009#newcode25 user/src/com/google/gwt/user/client/ui/DateLabel.java:25: * A ValueLabel that uses {...@link DateTimeFormatRenderer}. On 2010/11/18 05:46:19, rjrjr wrote:
Should add javadoc for the predefined format stuff, whatever
non-obvious things
the custom parser does.
Done. http://gwt-code-reviews.appspot.com/1099801/diff/26001/27009#newcode33 user/src/com/google/gwt/user/client/ui/DateLabel.java:33: public DateLabel(DateTimeFormat format) { On 2010/11/18 19:35:48, rjrjr wrote:
I see. Yes, if you could punch up the javadoc, something like:
Extends ValueLabel for convenience when dealing with dates and
DateTimeFormat,
especially in UiBinder templates. (Note that this class does not
accept
renderers. To do so use ValueLabel directly.)
Done. http://gwt-code-reviews.appspot.com/1099801/diff/26001/27014 File user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java (right): http://gwt-code-reviews.appspot.com/1099801/diff/26001/27014#newcode235 user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java:235: // overrides in RadioButton On 2010/11/18 19:35:48, rjrjr wrote:
HasValue really is the right thing.
I'd hold off on setName, and make editor compatibility the goal for
this patch. Editor compatibility only needs TakesValue, not HasValue; and value-change handling in radio buttons really isn't straight-forward (i.e. would have to be tested both automatically and manually in many browsers), so I'd rather go with just TakesValue for the moment. HasValue could still be added later, along with setName for instance.
Surely we can get CheckBox to extend SimpleCheckBox down the road.
Yes, it should be possible following a similar approach to InlineHyperlink/Hyperlink. http://gwt-code-reviews.appspot.com/1099801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
