http://gwt-code-reviews.appspot.com/1099801/diff/26001/27026 File user/test/com/google/gwt/uibinder/elementparsers/NumberLabelParserTest.java (right):
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27026#newcode145 user/test/com/google/gwt/uibinder/elementparsers/NumberLabelParserTest.java:145: b.append("<g:NumberLabel predefinedFormat='CURRENCY'>"); On 2010/11/18 10:17:55, tbroyer wrote:
I agree. Do you want me to create another review with this change?
(and update
this one rely on it; or rather include the NumberFormat change right
into this
review?)
Let's get this landed and do that as a separate patch (and add DATE_DEFAULT, TIME_DEFAULT, and DATE_TIME_DEFAULT to DateTimeFormat.PredefinedFormat as well).
There's a difference with DateLabelParser though, in that PredefinedFormat.CURRENCY would still have to be special-cased in the NumberLabelParser, at least when used with a currency code.
A currency code can be supplied in other cases as well, so we already have to deal with those. http://gwt-code-reviews.appspot.com/1099801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
