LGTM!
http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005 File user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005#newcode43 user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java:43: RpcToken getRpcToken(); How likely is it that developers will be providing their own implementations of ServiceDefTarget? We'd be breaking them by adding methods here. http://gwt-code-reviews.appspot.com/1107801/diff/3001/4009 File user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/3001/4009#newcode109 user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java:109: RpcToken.Class tokenClassToUse = remoteService.findAnnotationInTypeHierarchy(
80 columns
http://gwt-code-reviews.appspot.com/1107801/diff/13001/14002 File user/src/com/google/gwt/user/client/rpc/RpcToken.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/13001/14002#newcode28 user/src/com/google/gwt/user/client/rpc/RpcToken.java:28: public interface RpcToken extends Serializable { As mentioned in the draft design, I'm not sure RpcToken is the best name for this. It's really just a value that's implicitly passed along with each RPC. Maybe, RpcRequestHeader? But really I'd defer to GWT team for advice on naming here... http://gwt-code-reviews.appspot.com/1107801/diff/13001/14006 File user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/13001/14006#newcode82 user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java:82: if (((flags | VALID_FLAGS_MASK) ^ VALID_FLAGS_MASK) == 0) { Why not just return (that expression)? http://gwt-code-reviews.appspot.com/1107801/diff/13001/14008 File user/src/com/google/gwt/user/client/rpc/impl/RemoteServiceProxy.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/13001/14008#newcode276 user/src/com/google/gwt/user/client/rpc/impl/RemoteServiceProxy.java:276: protected void checkRpcTokenType(RpcToken token) { Perhaps javadoc? http://gwt-code-reviews.appspot.com/1107801/diff/13001/14010 File user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/13001/14010#newcode192 user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java:192: stob.addRootType(logger, icseType); Spurious whitespace at line-end. http://gwt-code-reviews.appspot.com/1107801/diff/13001/14020 File user/test/com/google/gwt/user/client/rpc/RpcTokenTest.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/13001/14020#newcode81 user/test/com/google/gwt/user/client/rpc/RpcTokenTest.java:81: token.tokenValue = "Drink kumys!"; Yikes! http://gwt-code-reviews.appspot.com/1107801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
