http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005
File user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java
(right):

http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005#newcode43
user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java:43:
RpcToken getRpcToken();
On 2010/11/22 19:33:42, jat wrote:
On 2010/11/22 03:52:05, meder wrote:
> On 2010/11/20 04:33:44, xtof wrote:
> > How likely is it that developers will be providing their own
implementations
> of
> > ServiceDefTarget? We'd be breaking them by adding methods here.
>
> I've seen it being done, so this will most definitely break some
code. I'm
> waiting for someone from GWT team to look at this and tell me if
this is fine
or
> if I should add another interface.

Do you have any reference to non-generated code that implements
ServiceDefTarget?  I would expect only mocks would do so.

It's mostly mocks but not all:
http://codesearch.google.com/codesearch?hl=en&lr=&q=%22implements+ServiceDefTarget%22+lang:java&sbtn=Search


That said, it wouldn't be much of a problem to put the RpcToken APIs
on another
interface.

Either way is fine with me.

http://gwt-code-reviews.appspot.com/1107801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to