http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005 File user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java (right):
http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005#newcode43 user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java:43: RpcToken getRpcToken(); On 2010/11/20 04:33:44, xtof wrote:
How likely is it that developers will be providing their own
implementations of
ServiceDefTarget? We'd be breaking them by adding methods here.
I've seen it being done, so this will most definitely break some code. I'm waiting for someone from GWT team to look at this and tell me if this is fine or if I should add another interface. http://gwt-code-reviews.appspot.com/1107801/diff/3001/4009 File user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/3001/4009#newcode109 user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java:109: RpcToken.Class tokenClassToUse = remoteService.findAnnotationInTypeHierarchy( On 2010/11/20 04:33:44, xtof wrote:
> 80 columns
Hmm...this is older version of code, but anyhow, this was fixed. http://gwt-code-reviews.appspot.com/1107801/diff/13001/14002 File user/src/com/google/gwt/user/client/rpc/RpcToken.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/13001/14002#newcode28 user/src/com/google/gwt/user/client/rpc/RpcToken.java:28: public interface RpcToken extends Serializable { On 2010/11/20 04:33:44, xtof wrote:
As mentioned in the draft design, I'm not sure RpcToken is the best
name for
this. It's really just a value that's implicitly passed along with
each RPC.
Maybe, RpcRequestHeader? But really I'd defer to GWT team for advice
on naming
here...
If everyone is ok with the proposed name, I can change it. http://gwt-code-reviews.appspot.com/1107801/diff/13001/14006 File user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/13001/14006#newcode82 user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java:82: if (((flags | VALID_FLAGS_MASK) ^ VALID_FLAGS_MASK) == 0) { On 2010/11/20 04:33:44, xtof wrote:
Why not just return (that expression)?
True! Done. http://gwt-code-reviews.appspot.com/1107801/diff/13001/14008 File user/src/com/google/gwt/user/client/rpc/impl/RemoteServiceProxy.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/13001/14008#newcode276 user/src/com/google/gwt/user/client/rpc/impl/RemoteServiceProxy.java:276: protected void checkRpcTokenType(RpcToken token) { On 2010/11/20 04:33:44, xtof wrote:
Perhaps javadoc?
Done. http://gwt-code-reviews.appspot.com/1107801/diff/13001/14010 File user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/13001/14010#newcode192 user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java:192: stob.addRootType(logger, icseType); On 2010/11/20 04:33:44, xtof wrote:
Spurious whitespace at line-end.
Done. http://gwt-code-reviews.appspot.com/1107801/diff/13001/14020 File user/test/com/google/gwt/user/client/rpc/RpcTokenTest.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/13001/14020#newcode81 user/test/com/google/gwt/user/client/rpc/RpcTokenTest.java:81: token.tokenValue = "Drink kumys!"; On 2010/11/20 04:33:44, xtof wrote:
Yikes!
Yum! http://gwt-code-reviews.appspot.com/1107801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
