http://gwt-code-reviews.appspot.com/1195801/diff/1/10 File user/src/com/google/gwt/media/dom/client/MediaElement.java (right):
http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode119 user/src/com/google/gwt/media/dom/client/MediaElement.java:119: * source have been buffered locally. Not all browsers support this feature. Can this be made explicit? Which browsers? http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode130 user/src/com/google/gwt/media/dom/client/MediaElement.java:130: * @return a String URL @return a String URL, or the empty string if there is no source http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode139 user/src/com/google/gwt/media/dom/client/MediaElement.java:139: * @return the time as a double @return the time, in seconds, as a double http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode156 user/src/com/google/gwt/media/dom/client/MediaElement.java:156: return this.defaultPlaybackRate || 1.0; Could the "|| 1.0" cause a defaultPlaybackRate of 0 to return 1.0? (Here, and elsewhere in this file.) http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode184 user/src/com/google/gwt/media/dom/client/MediaElement.java:184: * @return the initial time, or 0.0 if it has not been set Is it 0.0 for not-yet set, or for unknown? http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode220 user/src/com/google/gwt/media/dom/client/MediaElement.java:220: * source have been played. Not all browsers support this feature. Can this be made explicit? Which browsers? http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode264 user/src/com/google/gwt/media/dom/client/MediaElement.java:264: * source are seekable. Not all browsers support this feature. Can this be made explicit? Which browsers? http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode395 user/src/com/google/gwt/media/dom/client/MediaElement.java:395: * Causes the resource to be loaded. Can you javadoc when this should be used? From my reading of the spec, it's for when the user sets the source attribute, but is done automatically upon setting the src attribute? http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode440 user/src/com/google/gwt/media/dom/client/MediaElement.java:440: * @param time a number within the ranges given by {...@link #getSeekable() Is this unit in seconds? http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode452 user/src/com/google/gwt/media/dom/client/MediaElement.java:452: * Note that is should be a positive integer between 0.0 and 1.0. (Or, is negative allowed?) http://gwt-code-reviews.appspot.com/1195801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
